BroadcastStyle for RectDiagonal #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
===========================================
+ Coverage 0.00% 95.53% +95.53%
===========================================
Files 5 5
Lines 849 852 +3
===========================================
+ Hits 0 814 +814
+ Misses 849 38 -811
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Perhaps this warrants v1.1 as its a "new feature"? |
|
Yes, this may go in the upcoming 1.4 release. The version is already bumped on master, but it hasn't been tagged yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hooks into some of the functionality for structured matrices in
LinearAlgebra, and assuages some of the concerns raised in #265. After this, sparsity is often preserved when broadcasting over aRectDiagonal: